[BACKLOG-27905] Updated snowflake mondrian dialect to have snowflake …

[ricksjames]

…native regex and pass more mondrian integration tests

[wingman-pentaho]

Build Completed

🔥 This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -f 'pom.xml' -pl '.,mondrian' -P '!assemblies' -DrunITs=true -Dsurefire.runOrder=alphabetical -Dfailsafe.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands

mvn -B -f 'pom.xml' -pl '.,mondrian' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  demo/FoodMart.xml
  mondrian/pom.xml
  mondrian/src/it/java/mondrian/test/BasicQueryTest.java
  mondrian/src/it/java/mondrian/test/DialectTest.java
  mondrian/src/main/java/mondrian/spi/impl/SnowflakeDialect.java

Integration Test Coverage

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

⚠️ Coverage Changes: -0.1% (click to expand)

mondrian.olap.fun.BuiltinFunTable.56.new AbstractBooleanCalc() {...}

• Branch Change: -10% 🔻
• Complexity Change: -14.3% 🔻

mondrian.rolap.agg.SegmentBuilder

• Branch Change: -0.7% 🔻
• Complexity Change: -1.1% 🔻

mondrian.spi.impl.SnowflakeDialect

• Branch Change: 0%
• Complexity Change: -26.2% 🔻
• Instruction Change: -49.4% 🔻
• Line Change: -22.6% 🔻
• Method Change: -24.2% 🔻

🆕 mondrian.spi.impl.SnowflakeDialect.RegexParameters

• Coverage: 0% ❗

[kurtwalker]

Since we don't include all the other possible jdbc drivers, I think we should leave this out. Readme suggests defining a profile in settings.xml. I'd stick with that

[ricksjames]

fixed - removed changes to pom.xml.

[mkambol]

Sorta surprised the Foodmart.xml changes don't break a bunch of tests. Used to be there were hash checks in some tests.

[wingman-pentaho]

Build Completed

🔥 This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -f 'pom.xml' -pl '.,mondrian' -P '!assemblies' -DrunITs=true -Dsurefire.runOrder=alphabetical -Dfailsafe.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands

mvn -B -f 'pom.xml' -pl '.,mondrian' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  demo/FoodMart.xml
  mondrian/src/it/java/mondrian/test/BasicQueryTest.java
  mondrian/src/it/java/mondrian/test/DialectTest.java
  mondrian/src/main/java/mondrian/spi/impl/SnowflakeDialect.java

Integration Test Coverage

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

⚠️ Coverage Changes: -0.1% (click to expand)

mondrian.olap.fun.BuiltinFunTable.56.new AbstractBooleanCalc() {...}

• Branch Change: -10% 🔻
• Complexity Change: -14.3% 🔻

mondrian.rolap.agg.SegmentBuilder

• Branch Change: -0.7% 🔻
• Complexity Change: -1.1% 🔻

mondrian.rolap.agg.SegmentCacheManager.Actor

• Instruction Change: -6.4% 🔻
• Line Change: -3.5% 🔻

mondrian.spi.impl.SnowflakeDialect

• Branch Change: 0%
• Complexity Change: -26.2% 🔻
• Instruction Change: -49.4% 🔻
• Line Change: -22.6% 🔻
• Method Change: -24.2% 🔻

🆕 mondrian.spi.impl.SnowflakeDialect.RegexParameters

• Coverage: 0% ❗