Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate cache after deactivation in renewal flow #712

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

aviupadhyayula
Copy link
Member

Adds cache invalidation to deactivation script. Adds test case that checks whether cached clubs are flushed after running deactivation command.

For context: we run a command to deactivate all clubs at the beginning of the year. This kicks off the renewal cycle. The command changes club attributes but doesn't invalidate the cache. This results in incorrect behavior -- the frontend marks clubs as having been approved prematurely.

@aviupadhyayula aviupadhyayula changed the title Invalidate cache after deactivation in renewal script Invalidate cache after deactivation in renewal flow Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.29%. Comparing base (eb96a3d) to head (52dbea2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
+ Coverage   71.17%   71.29%   +0.11%     
==========================================
  Files          31       31              
  Lines        6835     6841       +6     
==========================================
+ Hits         4865     4877      +12     
+ Misses       1970     1964       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aviupadhyayula aviupadhyayula merged commit afaf673 into master Aug 28, 2024
9 checks passed
@aviupadhyayula aviupadhyayula deleted the avi/invalidate-cache-after-deactivation branch August 28, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant