Skip to content

Commit

Permalink
Revert "Hide approved=False clubs and temporarily disable broken fron…
Browse files Browse the repository at this point in the history
…tend che…" (#728)

This reverts commit 09efd62.
  • Loading branch information
rm03 committed Sep 24, 2024
1 parent 09efd62 commit 97803da
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/build-and-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ jobs:
black: false
ruff: true

frontend-check:
name: "Frontend Check"
uses: pennlabs/shared-actions/.github/workflows/react-check.yaml@v0.1
with:
path: frontend
nodeVersion: 20.11.1

build-backend:
name: Build backend
runs-on: ubuntu-latest
Expand Down
4 changes: 0 additions & 4 deletions backend/clubs/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -1008,10 +1008,6 @@ def to_representation(self, instance):
and instance.membership_set.filter(person=user).exists()
)
if not can_see_pending and not is_member:
if instance.approved is False:
raise serializers.ValidationError(
"This club has been removed from the platform."
)
historical_club = (
instance.history.filter(approved=True)
.order_by("-approved_on")
Expand Down
4 changes: 1 addition & 3 deletions backend/clubs/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -1149,9 +1149,7 @@ def get_queryset(self):
):
return queryset
else:
return queryset.filter(
Q(approved=True) | (Q(ghost=True) & Q(approved=None))
)
return queryset.filter(Q(approved=True) | Q(ghost=True))

def _has_elevated_view_perms(self, instance):
"""
Expand Down

0 comments on commit 97803da

Please sign in to comment.