Skip to content

Commit

Permalink
gitlint: Ignore signed-off-by line
Browse files Browse the repository at this point in the history
When checking for line length limits, ignore lines with Signed-off-by.
Some developers have a long name that would not fit within the limits.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
  • Loading branch information
nashif authored and Anas Nashif committed Jun 6, 2017
1 parent 7a01988 commit b520075
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .gitlint
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ words=wip,title
# (e.g. title-must-not-contain-word).
#regex=^US[0-9]*

[B1]
[max-line-length-with-exceptions]
# B1 = body-max-line-length
line-length=72

Expand Down
14 changes: 13 additions & 1 deletion scripts/gitlint/zephyr_commit_rules.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from gitlint.rules import CommitRule, RuleViolation, TitleRegexMatches, CommitMessageTitle, LineRule
from gitlint.rules import CommitRule, RuleViolation, TitleRegexMatches, CommitMessageTitle, LineRule, CommitMessageBody
from gitlint.options import IntOption, BoolOption, StrOption, ListOption
import re

Expand Down Expand Up @@ -68,3 +68,15 @@ def validate(self, title, _commit):
violation_message = "Title does not follow <subsystem>: <subject>"
if not pattern.search(title):
return [RuleViolation(self.id, violation_message, title)]

class MaxLineLengthExceptions(LineRule):
name = "max-line-length-with-exceptions"
id = "UC4"
target = CommitMessageBody
options_spec = [IntOption('line-length', 80, "Max line length")]
violation_message = "Line exceeds max length ({0}>{1})"

def validate(self, line, _commit):
max_length = self.options['line-length'].value
if len(line) > max_length and not line.startswith('Signed-off-by'):
return [RuleViolation(self.id, self.violation_message.format(len(line), max_length), line)]

0 comments on commit b520075

Please sign in to comment.