Skip to content

fix(ci): Disable provenance/sbom to fix ghcr.io manifest issues#35

Merged
PenguinzTech merged 3 commits intomainfrom
fix/docker-build-ghcr
Jan 22, 2026
Merged

fix(ci): Disable provenance/sbom to fix ghcr.io manifest issues#35
PenguinzTech merged 3 commits intomainfrom
fix/docker-build-ghcr

Conversation

@PenguinzTech
Copy link
Contributor

@PenguinzTech PenguinzTech commented Jan 21, 2026

Summary

  • Disable provenance and sbom generation in Docker builds to fix ghcr.io multi-arch manifest issues
  • Upgrade docker/build-push-action to v6
  • Add manifest verification step after push

Problem

The multi-arch Docker builds were creating manifest indexes in ghcr.io but the platform-specific images they referenced were missing ("manifest unknown" errors). This is a known issue with buildx attestation manifests and ghcr.io.

See: docker/build-push-action#820

Test plan

  • Verify CI builds complete successfully
  • Verify images can be pulled from ghcr.io after merge
  • Verify manifest verification step passes

Fixes #34

🤖 Generated with Claude Code

Summary by Sourcery

Update Docker image build workflow to address ghcr.io multi-arch manifest issues and add post-push verification.

Build:

  • Upgrade docker/build-push-action to v6 in the Docker image build workflow.
  • Disable provenance and SBOM generation in Docker builds to avoid ghcr.io multi-arch manifest problems.

CI:

  • Add a manifest verification step after pushing images to ensure ghcr.io manifests are available and inspectable.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 21, 2026

Reviewer's Guide

Updates the Docker CI workflow to use docker/build-push-action v6, disable provenance/SBOM attestation to avoid ghcr.io multi-arch manifest issues, and add a post-push manifest verification step for non-PR builds.

Sequence diagram for Docker image build, push, and manifest verification

sequenceDiagram
  actor Dev as Developer
  participant GH as GitHub_Actions
  participant BuildJob as Job_build-and-push
  participant Buildx as Docker_buildx
  participant GHCR as ghcr_io

  Dev->>GH: Push to default branch
  GH->>BuildJob: Start workflow docker-build.yml

  BuildJob->>BuildJob: Step meta (generate tags, labels)

  BuildJob->>Buildx: docker/build-push-action v6<br/>provenance=false, sbom=false
  Buildx->>GHCR: Push multi-arch image
  Buildx-->>BuildJob: digest, tags

  alt Not_pull_request_event
    BuildJob->>GHCR: docker manifest inspect IMAGE_TAG
    loop Up_to_3_attempts
      GHCR-->>BuildJob: manifest available?
    end
  else Pull_request_event
    BuildJob->>BuildJob: Skip manifest verification
  end
Loading

File-Level Changes

Change Details Files
Update Docker build-and-push step to use build-push-action v6 and disable provenance/SBOM attestations to work around ghcr.io multi-arch manifest issues.
  • Bump docker/build-push-action from v5 to v6 in the build-and-push job.
  • Add provenance: false and sbom: false to the build-push-action inputs, with inline comments documenting the related upstream issue.
  • Keep existing build arguments, labels, and cache configuration unchanged.
.github/workflows/docker-build.yml
Add a non-PR manifest verification step after pushing images to ensure multi-arch manifests are available in the registry.
  • Introduce a Verify image manifest step that only runs when the event is not a pull_request.
  • Derive the image tag from the first tag produced by the metadata step and log which image is being verified.
  • Poll docker manifest inspect up to three times with 10s delays to allow registry propagation, printing the first part of the manifest on success and emitting a warning (but not failing the job) if verification never succeeds.
.github/workflows/docker-build.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#34 Ensure CI/CD pushes valid multi-arch Docker images to ghcr.io where manifest indexes have corresponding platform-specific images/blobs (no more 'manifest unknown' errors).
#34 Ensure CI/CD publishes expected plain semantic version tags (e.g., v3.0.5) to the Docker registry in addition to alpha/beta/build-specific tags. The PR only updates the docker/build-push-action version, disables provenance/SBOM, and adds a manifest verification step. It does not modify any tag configuration or metadata generation logic that would add plain version tags like v3.0.5 to the pushed images.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The manifest verification step currently waits at most ~30s with a fixed interval; consider making the retry count and delay configurable (e.g., via environment variables) or using a longer/backoff-based wait to better tolerate slower ghcr.io propagation without raising spurious warnings.
  • Disabling provenance and SBOM generation is hard-coded; if this is intended as a temporary workaround, you might want to gate it behind an input or environment flag so it’s easy to re-enable once the upstream issue is resolved.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The manifest verification step currently waits at most ~30s with a fixed interval; consider making the retry count and delay configurable (e.g., via environment variables) or using a longer/backoff-based wait to better tolerate slower ghcr.io propagation without raising spurious warnings.
- Disabling provenance and SBOM generation is hard-coded; if this is intended as a temporary workaround, you might want to gate it behind an input or environment flag so it’s easy to re-enable once the upstream issue is resolved.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

Test Summary

Job Results

  • Python Lint: skipped
  • Python Tests: skipped
  • Node.js Tests: skipped
  • Security Scan: success
  • License Check: success

Note: Integration tests temporarily disabled during PyDAL migration

Commit: 98fdf24
Branch: 35/merge
Workflow Run: #243

@PenguinzTech PenguinzTech force-pushed the fix/docker-build-ghcr branch from 241b326 to e5d5649 Compare January 21, 2026 17:26
@socket-security
Copy link

socket-security bot commented Jan 21, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Low
Unmaintained: npm lodash.isarguments was last published 9 years ago

Last Publish: 8/13/2016, 5:40:07 PM

From: ?npm/lodash.isarguments@3.1.0

ℹ Read more on: This package | This alert | What are unmaintained packages?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/lodash.isarguments@3.1.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions
Copy link

Test Summary

Job Results

  • Python Lint: skipped
  • Python Tests: skipped
  • Node.js Tests: skipped
  • Security Scan: success
  • License Check: success

Note: Integration tests temporarily disabled during PyDAL migration

Commit: cea2657
Branch: 35/merge
Workflow Run: #244

- Upgrade docker/build-push-action to v6
- Disable provenance and sbom generation for cleaner manifest structure

Fixes #34

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@PenguinzTech PenguinzTech force-pushed the fix/docker-build-ghcr branch from e5d5649 to a332cf1 Compare January 22, 2026 15:01
@github-actions
Copy link

Test Summary

Job Results

  • Python Lint: skipped
  • Python Tests: skipped
  • Node.js Tests: skipped
  • Security Scan: success
  • License Check: success

Note: Integration tests temporarily disabled during PyDAL migration

Commit: cf48dd4
Branch: 35/merge
Workflow Run: #248

Removes [tar](https://github.com/isaacs/node-tar). It's no longer used after updating ancestor dependency [argon2](https://github.com/ranisalt/node-argon2). These dependencies need to be updated together.


Removes `tar`

Updates `argon2` from 0.31.2 to 0.44.0
- [Release notes](https://github.com/ranisalt/node-argon2/releases)
- [Commits](ranisalt/node-argon2@v0.31.2...v0.44.0)

---
updated-dependencies:
- dependency-name: tar
  dependency-version: 
  dependency-type: indirect
- dependency-name: argon2
  dependency-version: 0.44.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​argon2@​0.31.2 ⏵ 0.44.0100 +10100100 +182100

View full report

@github-actions
Copy link

Test Summary

Job Results

  • Python Lint: skipped
  • Python Tests: skipped
  • Node.js Tests: skipped
  • Security Scan: success
  • License Check: success

Note: Integration tests temporarily disabled during PyDAL migration

Commit: e84c4c3
Branch: 35/merge
Workflow Run: #249

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@PenguinzTech PenguinzTech merged commit feeb31d into main Jan 22, 2026
22 of 23 checks passed
@github-actions
Copy link

Test Summary

Job Results

  • Python Lint: skipped
  • Python Tests: skipped
  • Node.js Tests: success
  • Security Scan: success
  • License Check: success

Note: Integration tests temporarily disabled during PyDAL migration

Commit: a143637
Branch: 35/merge
Workflow Run: #250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] cicd not properly pushing to the docker registry for github

1 participant