Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting lessons from zlib-rs
The comment below has a table with the flags (see dropdown). The coverage percentage itself is not too interesting, but the delta may be in the future. The real advantage is that you can now see whether the fuzzer actually hits the logic you expect.
Doing some clicking through the interface, this is the coverage for
fuzz-packet_parsing_sound
: https://app.codecov.io/github/pendulum-project/ntpd-rs/commit/b560a6393de61168dde532292c01bf5480e22af9/tree/ntp-proto/src?flags%5B0%5D=fuzz-packet_parsing_sound&dropdown=coverageE.g. here you can see that the fuzzer is unable to generate a valid
NtsEncryptedField
:https://app.codecov.io/github/pendulum-project/ntpd-rs/commit/b560a6393de61168dde532292c01bf5480e22af9/blob/ntp-proto/src/packet/extension_fields.rs?flags%5B0%5D=fuzz-packet_parsing_sound&dropdown=coverage#L660
At this point I'm not that familiar with the details of the codebase, so you'll have to look at the results here to see if anything jumps out. It's straightforward to add more fuzzers, and they all run in parallel so CI time does not increase if you do so.