Quick sizing cursor logic separation #1921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This basically takes the Quick sizing logic from StrokeTool and creates a simplified Tool from that logic.
Rather than a fixed 45 deg it will now offset in the opposite direction of the cursor, which should make adjustments feel more natural.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a bigger tool logic separation i'm working on...
As my changes were growing, at a similar rate of #1906, I decided to create a separate PR instead, to avoid PR's with lots of changes.
As such this PR focuses on the quick sizing part, separating it into its own tool and let StrokeTool deal with how the canvas cursor should be updated.
Some of the quick sizing logic had also leaked into CanvasCursorPainter, which shouldn't be necessary anymore. I've simplified CanvasCursor to the point where it just focuses on drawing a radial cursor.
In addition I've also updated the quick sizing logic so that it updates the offset based on the current position, rather than a fixed 45 deg angle.
closes #1871 As it doesn't depend on a fixed angle anymore.