Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more cache issues. #1581

Merged
merged 7 commits into from
Mar 2, 2021
Merged

Conversation

MrStevns
Copy link
Member

@MrStevns MrStevns commented Feb 28, 2021

Another PR, this one focuses on the ongoing cache regressions that returned after i reworked the logic...

What's added:

  • frameModified on import image and movie
  • frameModified on onCurrentFrameChanged, fixes camera interpolation not being visible.
  • frameModified on undo/redo

@MrStevns MrStevns added the Bug label Feb 28, 2021
@MrStevns MrStevns changed the title Bugfix/cache issues Fix more cache issues. Feb 28, 2021
@MrStevns MrStevns force-pushed the bugfix/cache-issues branch from efdd90a to 6ecbbdb Compare February 28, 2021 14:10
@davidlamhauge davidlamhauge self-requested a review March 1, 2021 06:52
Copy link
Contributor

@davidlamhauge davidlamhauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost everything works perfect.
Camera interpolation works only when you are on the camera layer. If you choose the Bitmap or Vector layer, the camera interpolation is not updated.
Besides that: Good work!

app/src/actioncommands.cpp Outdated Show resolved Hide resolved
MrStevns added 3 commits March 1, 2021 17:02
This should happen regardless of whether we're on a camera layer or not.. because of potential camera interpolation.
@MrStevns
Copy link
Member Author

MrStevns commented Mar 1, 2021

The interpolation issue should be fixed now and the review requests should have been addressed.

Copy link
Contributor

@davidlamhauge davidlamhauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrStevns MrStevns merged commit 1f04337 into pencil2d:master Mar 2, 2021
@MrStevns MrStevns deleted the bugfix/cache-issues branch March 2, 2021 16:40
@chchwy chchwy added this to the 0.7.0 milestone Jul 15, 2021
@MrStevns MrStevns modified the milestones: 0.7.0, v0.6.7 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants