Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Portal knights #2179

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Portal knights #2179

merged 2 commits into from
Mar 5, 2023

Conversation

QuintenQVD0
Copy link
Collaborator

@QuintenQVD0 QuintenQVD0 commented Mar 5, 2023

Description

add Portal knights

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

Copy link

@Toaaa Toaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfectly. 👍🏻

@QuintenQVD0 QuintenQVD0 merged commit f2b1e50 into master Mar 5, 2023
@QuintenQVD0 QuintenQVD0 deleted the Portal-Knights branch March 5, 2023 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants