Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Changed max members and token field #2162

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Conversation

PilaScat
Copy link
Contributor

@PilaScat PilaScat commented Feb 26, 2023

Description

Updated to 12 max members and 60 for token length

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • You verify that the start command applied does not use a shell script
  • Did you branch your changes and PR from that branch and not from your master branch?
  • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

Updated to 12 max members and 60 for token length
Copy link
Collaborator

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not read the checklist! this is not exported from a panel

@PilaScat
Copy link
Contributor Author

It's the same, I don't know how to make it otherwise

@PilaScat
Copy link
Contributor Author

I screwed up a bit, hope now its all ok

@QuintenQVD0
Copy link
Collaborator

I screwed up a bit, hope now its all ok

yea, no problem. We don't bite. I exported it from the panel so technicly I can merge this but you had a build error I saw.
can you post that here? and are you on arm64?

@PilaScat
Copy link
Contributor Author

In theory it shouldn't be because of my changes since the server hasn't started yet and the original docker I'm already using has always worked with these settings

@PilaScat
Copy link
Contributor Author

Here the compiler error: (I'm on x86_64)
image

@Z3r0byte
Copy link
Contributor

Must admit that I didn't look too closely at which values should be allowed there since I don't use them, so thanks for the PR. It seems indeed that the yuzu team has made some changes to their source code in the meantime, making that warning pop up. However, compilation still succeeds as its only a warning (just ran a reinstall and that worked).

Maybe there is some way to suppress that warning, although they can of course also be useful for debugging if something goes wrong, so I am not sure if that is something we want to do.

@QuintenQVD0
Copy link
Collaborator

LGTM!

@QuintenQVD0 QuintenQVD0 merged commit 885d651 into pelican-eggs:master Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants