Skip to content

composer update#1966

Merged
notAreYouScared merged 1 commit into
mainfrom
charles/filament-update
Dec 8, 2025
Merged

composer update#1966
notAreYouScared merged 1 commit into
mainfrom
charles/filament-update

Conversation

@notAreYouScared
Copy link
Copy Markdown
Member

No description provided.

@notAreYouScared notAreYouScared self-assigned this Dec 7, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 7, 2025

📝 Walkthrough

Walkthrough

Changes involve parameter renaming and refactoring of internal variable aliases across multiple minified JavaScript components, with updates to public function signatures in textarea and tabs components while maintaining core functionality.

Changes

Cohort / File(s) Summary
Core Module Refactoring
public/js/filament/filament/app.js
Internal variable aliases renamed within minified IIFE (e.g., tere, xdefineProperty); functional structure and public exports preserved.
Component API Updates
public/js/filament/forms/components/textarea.js
Parameter destructuring renamed (initialHeight:tinitialHeight:i, shouldAutosize:ishouldAutosize:s, state:sstate:h); resize() logic refactored to temporarily zero element height for recalculation before applying new dimensions.
Tab Component Enhancement
public/js/filament/schemas/components/tabs.js
Default export function renamed with expanded public API parameters; added state for resize handling, debounce timers, and dropdown calculations; preserves query string syncing and Livewire commit behaviors.

Possibly related PRs

  • Filament v4.1 #1761: Contains identical internal identifier refactoring in public/js/filament/filament/app.js minified module.

Pre-merge checks

❌ Failed checks (1 warning, 2 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'composer update' is vague and does not clearly describe the actual changes, which involve minified JavaScript refactoring and updates to multiple Filament UI components. Provide a more descriptive title that indicates this is a Filament package update with JavaScript component changes, such as 'Update Filament UI dependencies and refactor JavaScript components'.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether the intention behind the changes is explained. Add a description explaining the purpose of the Filament update, what changes were made to JavaScript components, and why these updates were necessary.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71bd267 and 0c4ef72.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • public/js/filament/filament/app.js (1 hunks)
  • public/js/filament/forms/components/textarea.js (1 hunks)
  • public/js/filament/schemas/components/tabs.js (1 hunks)
🔇 Additional comments (3)
public/js/filament/forms/components/textarea.js (1)

1-1: Improved textarea resize logic.

The updated resize() method now:

  1. Returns early if scrollHeight is unavailable
  2. Temporarily sets height to "0px" to force recalculation (fixes shrinking behavior)
  3. Only updates the wrapper when the height actually changes

This is a common pattern for fixing textarea autosize issues where the textarea would grow but never shrink. The changes appear to be an improvement from the updated Filament dependency.

public/js/filament/filament/app.js (1)

1-1: These are minified JavaScript assets from the Filament v4.3.0 composer package update.

The file public/js/filament/filament/app.js and related files in public/js/filament/ are assets published by the Filament PHP package (currently pinned to ~4.0 in composer.json, v4.3.0 in composer.lock). These minified files are distributed as-is from the vendor package and should not be reviewed line-by-line.

No action needed—these files are expected to change when running composer update on Filament dependencies. They are properly tracked in version control as part of the package distribution.

Likely an incorrect or invalid review comment.

public/js/filament/schemas/components/tabs.js (1)

1-1: No action needed—this is minified distribution code from the Filament framework.

The export name change from u to I occurs in public/js/filament/schemas/components/tabs.js, which is built/compiled output from Filament v4.3.0. Function names in minified code are implementation details, not a public API. Filament components are loaded through Alpine.js registration by component name, not by importing the function itself. Minified variable/function name changes are expected with every build and do not constitute breaking changes.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@notAreYouScared notAreYouScared merged commit 7a95712 into main Dec 8, 2025
25 checks passed
@notAreYouScared notAreYouScared deleted the charles/filament-update branch December 8, 2025 15:46
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants