Skip to content

Commit

Permalink
fix(Dockerimage): Remove unnecessary compiler toolchain dependencies
Browse files Browse the repository at this point in the history
After `better-sqlite3` added support for pre-compiled binaries in
https://github.com/JoshuaWise/better-sqlite3/releases/tag/v6.0.0, we no
longer need to install a compiler toolchain to run `npm install` in our
Docker images.

pelias/docker-baseimage#23 is workong on
removing the compiler toolchain from our Pelias baseimages. In order for
the toolchain to be removed from the whosonfirst image in particular, we
also need to remove those dependencies here.

Until that PR is merged, this change is effectively a no-op. After,
between the two PRs we reduce the size of the whosonfirst docker image
from 490MB to 261MB, an impressive 221MB savings!
  • Loading branch information
orangejulius committed Nov 1, 2021
1 parent ff4bee8 commit 921278e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM pelias/baseimage

# downloader apt dependencies
# note: this is done in one command in order to keep down the size of intermediate containers
RUN apt-get update && apt-get install -y autoconf automake libtool pkg-config python bzip2 lbzip2 unzip && rm -rf /var/lib/apt/lists/*
RUN apt-get update && apt-get install -y bzip2 lbzip2 unzip && rm -rf /var/lib/apt/lists/*

# change working dir
ENV WORKDIR /code/pelias/whosonfirst
Expand Down

0 comments on commit 921278e

Please sign in to comment.