Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower german quotation mark and fix tests #481

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

taygun
Copy link
Contributor

@taygun taygun commented Oct 28, 2021

👋 I've added the german lower quotation mark as presented in this issue, updated the spec tests and added a new integration test for this case.


Here's the reason for this change 🚀

  • Fixes pelias/pelias#1569

Here's what actually got changed 👏


Here's how others can test the changes 👀

@missinglink
Copy link
Member

this looks perfect, I'm not sure why the CI isn't running but once I can confirm it passes we can merge this.

@missinglink
Copy link
Member

thanks!

for fun: https://jakubmarian.com/map-of-quotation-marks-in-european-languages/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants