Skip to content

Commit

Permalink
CI: Remove Node.js 12 from build matrix
Browse files Browse the repository at this point in the history
We normally try to keep all our CI configurations identical, but the
schema repository is a bit of a special case since it has to do so many
extra things around Elasticsearch.

Apparently, one of those extra things, `npm install -g npm`, now
installs a new enough version of NPM that it doesn't work on Node.js 12.

We are removing Node.js 12 support globally soon anyway in
pelias/pelias#950,
so we might as well remove it here to make all the tests pass again.
  • Loading branch information
orangejulius committed Jul 3, 2023
1 parent 777b824 commit 5f25659
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-20.04]
node-version: [12.x, 14.x, 16.x]
node-version: [14.x, 16.x]
steps:
- uses: actions/checkout@v2
- name: Install node.js ${{ matrix.node-version }}
Expand All @@ -27,7 +27,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-20.04]
node-version: [12.x, 14.x, 16.x]
node-version: [14.x, 16.x]
es-version: [7.6.1]
jdk-version: [oraclejdk11]
steps:
Expand Down

0 comments on commit 5f25659

Please sign in to comment.