Skip to content

Commit

Permalink
Remove version from package.json
Browse files Browse the repository at this point in the history
  • Loading branch information
@orangejulius
orangejulius committed Jul 28, 2016
1 parent 167479d commit 20fa325
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "pelias-schema",
"author": "mapzen",
"version": "3.1.0",
"description": "Elasticsearch schema files and tooling for Pelias",
"homepage": "https://github.com/pelias/schema",
"license": "MIT",
Expand Down

4 comments on commit 20fa325

@sheerun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I get "no version provided in package.json" error in npm@3 when installing directly from this repository

@orangejulius
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. The answer is because semantic release wants it that way, but we also run into problems because of this, since it means we can't point other repositories at branches from github.

I've heard from @trescube that setting the version to 0.0.0-semantic-release or something else to signify that the version number there is not the right one works. @trescube can you share where you read about this?

@sheerun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with 0.0.0 as long as it can install with npm pointed directly to github repo.

@orangejulius
Copy link
Member Author

@orangejulius orangejulius commented on 20fa325 Jul 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've added a version number back to all our repos (in the master branch). If there are any other issues like this please let us know, and thanks for reporting!

Please sign in to comment.