ES8: Remove bounding box query type parameter#140
Merged
orangejulius merged 1 commit intomasterfrom May 19, 2025
Merged
Conversation
The parameter has been deprecates in 7.14 as it is a no-op. see elastic/elasticsearch#74536
Member
|
Looks good to me 👍 I'm still not clear on when exactly this became a no-op and what affect unsetting it will have on older version. I've asked for clarification but I suspect that either way it won't have a huge impact. Happy to merge this as-is, let's just see if we get a response from them first. |
Member
Author
|
I ran a acceptance test between v7 and v8 and nothing change. But since |
Joxit
added a commit
to pelias/api
that referenced
this pull request
May 7, 2025
1 task
Member
|
Yeah, looks good to me. I've just run this through all our tests and there seems to be no difference. From the Elasticsearch docs it sounds like this parameter has had no effect for some time. |
Joxit
added a commit
to pelias/api
that referenced
this pull request
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter has been deprecates in 7.14 as it is a no-op.
see elastic/elasticsearch#74536