move away from event-stream, replace with stream-mock #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
force-pushed
the
feature/move-away-from-event-stream
branch
from
d517513
to
d3271b6
Compare
|
nice! good to see this merged :) |
8 tasks
michaelkirk
added a commit
to michaelkirk-pelias/whosonfirst
that referenced
this pull request
Dec 11, 2023
Part of pelias/pelias#801 Technique cribbed from pelias/openaddresses#457
missinglink
pushed a commit
to pelias/whosonfirst
that referenced
this pull request
Dec 12, 2023
Part of pelias/pelias#801 Technique cribbed from pelias/openaddresses#457
michaelkirk
added a commit
to michaelkirk-pelias/wof-admin-lookup
that referenced
this pull request
Dec 12, 2023
Part of pelias/pelias#801 Technique cribbed from pelias/openaddresses#457
missinglink
pushed a commit
to pelias/wof-admin-lookup
that referenced
this pull request
Dec 13, 2023
* move away from event-stream, replace with stream-mock Part of pelias/pelias#801 Technique cribbed from pelias/openaddresses#457 * share test_stream implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #429 as replacement
I pulled the code from
benetisand cleaned up the tests as perorangejuliuscomments so we can merge this.Also rebased
masterand fixed one tests. that came in since the original PR.Connects pelias/pelias#801