Add build-essential apt package to builder image #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in pelias/docker-libpostal_baseimage#11, Ubuntu 22 has some slightly differing package install semantics where we need to install the `build-essential` package to get `make` and all the other tools needed to compile against libpostal. This Dockerfile uses a builder image to do all the compiling, and then the compiled results are moved to a new, slim, Docker image, so this change doesn't affect the final image much. It's just needed to keep everything working for Ubuntu 22 pelias/pelias#951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in pelias/docker-libpostal_baseimage#11, Ubuntu 22 has some slightly differing package install semantics where we need to install the
build-essentialpackage to getmakeand all the other tools needed to compile against libpostal.This Dockerfile uses a builder image to do all the compiling, and then the compiled results are moved to a new, slim, Docker image, so this change doesn't affect the final image much.
It's just needed to keep everything working for Ubuntu 22
pelias/pelias#951