Initial Japanese Labels #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #49 to improve labels for Japan.
Japanese addressing formats are quite complicated and vary from region to region. Also, there are distinctly different formats for when addresses are written in English (or, presumably, other European languages) versus Japanese. This PR is concerned with only the English address format variant.
For the most part, this PR works by adding all the relevant parent elements to the label, as described in the Wikipedia page for the Japanese addressing system. There's also a small bit of Japan-specific deduplication for label elements.
There are examples taken from our actual OSM and OpenAddresses data across Japan. Most of these examples are addresses, but POIs and admin areas are also included.