improved handling of CSV comments #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
reviewed
Mar 1, 2022
| @@ -33,22 +33,22 @@ | |||
| "url": "https://github.com/pelias/geonames/issues" | |||
| }, | |||
| "engines": { | |||
| "node": ">=l2.0.0" | |||
There was a problem hiding this comment.
wow yeah, this is definitely a typo. It doesn't really affect much fortunately, but good catch!
orangejulius
reviewed
Mar 1, 2022
| @@ -6,7 +6,7 @@ | |||
| "homepage": "https://pelias.io", | |||
| "license": "MIT", | |||
| "scripts": { | |||
| "download_metadata": "mkdirp metadata && node bin/updateMetadata.js", | |||
| "download_metadata": "mkdir -p metadata && node bin/updateMetadata.js", | |||
orangejulius
approved these changes
Mar 1, 2022
|
agh woops, so the
I suspect there's just a weird bug in |
|
opened an issue upstream adaltas/node-csv#325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in #404 (comment) there seems to be a weird bug with how the geonames metatadata files are encoding comments, (I think!)
using this custom comment handler stream we're able to work around the issue, although I'm still not clear why the
commentoption from https://csv.js.org/parse/options/ (andsed '/^#/d') doesn't do the same thing 🤷I've also taken the opportunity to do some simple housekeeping tasks:
csv-parsemodulebomoption forcsv-parseas we have done in other modulesmkdirpmodule introduced in Used mkdirp in download_metadata script #185, since that time we've consolidated on Docker and Windows has made progress in its terminal utilities, I hope it's no longer required.enginesdefinition inpackage.jsonfrom>=l2.0.0to>=12.0.0, @orangejulius is this just a typo?The 'actual work' here is:
comment: ''in the csv options to disable stripping comments within that libsplit2and the newthroughstreams to handle this ourselves.resolves #404