feat(json): Allow empty addendum json #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joxit
approved these changes
Oct 9, 2020
| const documentStream = DocumentStream.create('prefix', stats); | ||
|
|
||
| test_stream([input], documentStream, function(err, actual) { | ||
| // console.log(JSON.stringify(actual, null, 2)); |
|
|
||
|
|
||
| test_stream([input], documentStream, function(err, actual) { | ||
| console.log(JSON.stringify(actual, null, 2)); |
|
|
||
|
|
||
| test_stream([input], documentStream, function(err, actual) { | ||
| console.log(JSON.stringify(actual, null, 2)); |
blackmad
changed the title
|
You did not remove lines with |
|
Apologies I thought I did push the console log. My computer just restarted
for a forced upgrade. Will check again when it completes.
Also apologies on using merge instead of squash.
What’s conventional commit?
On Fri, Oct 9, 2020 at 6:34 PM Jones Magloire ***@***.***> wrote:
You did not remove lines with console.log?
Don't forget to use Conventional Commit to trigger release...
Use squash instead of merge
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#81 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADMZMF3HWQDHKYSFJCGXATSJ6FXBANCNFSM4SKOTFYA>
.
--
*David Blackman*
creative technologist & wandering
help me find my purpose <http://purpose.blackmad.com>
|
|
Conventional commit = semantic versioning, got it.
I thought that’s what I was doing by renaming the commit to feat(Json): -
should I have done something different?
On Fri, Oct 9, 2020 at 6:35 PM David Blackman ***@***.***> wrote:
Apologies I thought I did push the console log. My computer just restarted
for a forced upgrade. Will check again when it completes.
Also apologies on using merge instead of squash.
What’s conventional commit?
On Fri, Oct 9, 2020 at 6:34 PM Jones Magloire ***@***.***>
wrote:
> You did not remove lines with console.log?
> Don't forget to use Conventional Commit to trigger release...
> Use squash instead of merge
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#81 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADMZMF3HWQDHKYSFJCGXATSJ6FXBANCNFSM4SKOTFYA>
> .
>
--
*David Blackman*
creative technologist & wandering
help me find my purpose <http://purpose.blackmad.com>
--
*David Blackman*
creative technologist & wandering
help me find my purpose <http://purpose.blackmad.com>
|
This means that the first line of the commit should use the conventional commit spec. Here, you use the Conventional Commit on the PR title and not on your commits. And in the merge commit, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a csv import that was silently failing because my addendum_json_XXX field was empty in some rows.
This change allows for empty values in addenum_json_XXX fields and adds a lot of tests for both that field and other json fields in csv import
In a separate change, I will attempt to print out badRecordCount somewhere, and in another I will propose we log failed rows to stderr