All structured queries show result match_type as fallback#780
Merged
All structured queries show result match_type as fallback#780
Conversation
orangejulius
approved these changes
Jan 17, 2017
Member
orangejulius
left a comment
orangejulius
left a comment
There was a problem hiding this comment.
lots of code but it looks great
| * | ||
| * They do not map 1:1 to our layers so the following somewhat complicated | ||
| * mapping structure is needed to set clear rules for comparing what was requested | ||
| * by the query and what has been received as a result to determine if a fallback occurred. |
Member
There was a problem hiding this comment.
yikes. complicated, but i think necessary and pretty readable.
|
|
||
| return ( | ||
| // verify that more granular properties are not set | ||
| notSet(req.clean.parsed_text, rule.notSet) && |
Member
There was a problem hiding this comment.
this part ends up really clean, quite nice
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pelias/pelias#493
Looks like all queries of the
fallbackvariety were suffering from this issue, not onlystructured. It would show up anytime there was a query that hadcityidentified by the query parser.