let users of the module to determine their logging configuration #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstich
added a commit
that referenced
this pull request
Mar 5, 2016
let users of the module to determine their logging configuration
|
Thanks for your pull request. I didn't realize that it would have that side-effect. I will update the data and then I think we should have a new minor release as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the configuration of logging out of the top-level and into main, users using tzwhere interactively still get logging while consumers using the library as a library don't have their logging config impacted.
The use of logging.basicConfig at the top level has been causing some of our applications to print all of their logs to stdout for a few days now.