Remove dependence on outdated minimist#190
Merged
afrokick merged 2 commits intopeers:masterfrom May 11, 2020
Merged
Conversation
Optimist is no longer maintained. It has not been updated since 2014, even for basic security updates. Thus this change replaces it with its spiritual successor, yargs, which is still actively maintained. This is also a first step to removing peerjs' dependence on an outdated version of minimist that has known security vulnerabilities.
This change removes the last bit of dependence on a version of minimist that has a known prototype pollution vulnerability.
Member
|
Thanks, @hobindar |
This was referenced Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain versions of minimist have a known security vulnerability and
thus should not be used a dependency. See CVE-2020-7598.
This change removes peerjs' dependence on said versions of minimist.
It does this by replacing its usage of optimist, which is no longer
maintained, with yargs, its spiritual successor. It also updates the
transitive dependencies in package-lock.json as needed.
Resolves #189