Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add surcharge model and api request handlers #124

Merged
merged 24 commits into from
Nov 29, 2023
Merged

feat: Add surcharge model and api request handlers #124

merged 24 commits into from
Nov 29, 2023

Conversation

anki247
Copy link
Collaborator

@anki247 anki247 commented Sep 13, 2023

  • Added surcharge model
  • API request handlers

@anki247 anki247 changed the title Add surcharge model and api request handlers feat: Add surcharge model and api request handlers Sep 13, 2023
jhnns
jhnns reviewed Sep 13, 2023
View reviewed changes
src/models/surcharge.ts Outdated Show resolved Hide resolved
src/models/surcharge.ts Outdated Show resolved Hide resolved
src/lib/requiredParams.ts Outdated Show resolved Hide resolved
src/clockodo.ts Show resolved Hide resolved
anki247 and others added 4 commits September 13, 2023 21:56
jhnns
jhnns reviewed Sep 26, 2023
View reviewed changes
src/models/surcharge.ts Outdated Show resolved Hide resolved
src/clockodo.ts Outdated Show resolved Hide resolved
src/clockodo.ts Outdated Show resolved Hide resolved
src/clockodo.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
jhnns
jhnns requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@jhnns jhnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found minor problems. After that, we're good to go :)

anki247 and others added 7 commits September 28, 2023 09:40
@anki247 @jhnns
Update src/clockodo.ts
a229456 
Co-authored-by: Johannes Ewald <johannes.ewald@peerigon.com>
@anki247 @jhnns
Update src/models/surcharge.ts
23d322c 
Co-authored-by: Johannes Ewald <johannes.ewald@peerigon.com>
@anki247 @jhnns
Update src/clockodo.ts
f55693c 
Co-authored-by: Johannes Ewald <johannes.ewald@peerigon.com>
@anki247
update api to v2
853f7f4
@anki247
revert changelog
6916464
@anki247
revert changelog
f48b130
@anki247
revert changelog
c23693f
jhnns
jhnns approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@jhnns jhnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor nitpicks :)

src/models/targethours.ts Show resolved Hide resolved
src/models/dateTime.ts Outdated Show resolved Hide resolved
src/clockodo.ts Outdated Show resolved Hide resolved
src/clockodo.ts Outdated Show resolved Hide resolved
@jhnns
Copy link
Member

jhnns commented Oct 24, 2023

@dsumer I think this is WIP as we're still waiting for the naming changes in the backend?

@dsumer dsumer changed the title feat: Add surcharge model and api request handlers WIP: feat: Add surcharge model and api request handlers Oct 24, 2023
dsumer
dsumer reviewed Nov 17, 2023
View reviewed changes
src/clockodo.ts Outdated Show resolved Hide resolved
dsumer
dsumer reviewed Nov 28, 2023
View reviewed changes
src/clockodo.ts Outdated Show resolved Hide resolved
@dsumer dsumer changed the title WIP: feat: Add surcharge model and api request handlers feat: Add surcharge model and api request handlers Nov 28, 2023
@mrclickbits mrclickbits merged commit 4447bc2 into main Nov 29, 2023
3 checks passed
@mrclickbits mrclickbits deleted the add-surcharge-model branch November 29, 2023 08:09
github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
@semantic-release-bot
chore(release): 23.1.0 [skip ci]
c0c7ca1 
# [23.1.0](v23.0.0...v23.1.0) (2023-11-29)

### Features

* Add surcharge model and api request handlers ([#124](#124)) ([4447bc2](4447bc2))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 23.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsumer dsumer dsumer left review comments

@jhnns jhnns jhnns approved these changes

@mrclickbits mrclickbits Awaiting requested review from mrclickbits

@florianwittmann florianwittmann Awaiting requested review from florianwittmann

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anki247 @jhnns @dsumer @mrclickbits