Skip to content

Conversation

Masa331
Copy link

@Masa331 Masa331 commented Oct 22, 2020

Hi there,

thanks for this wonderful gem

this pull requests adds 2 features to it

  1. respects current page's url params. Until now page params were discarder(they were ignored when generating url with with :lineprofiler => true
  2. adds simple modal toggler. When profiling is active, it adds hide/show toggler next to profiler link in Peek menu. This solves Feature request: close or hide button  #10

happy to update the patch if you don't like something, just let me know

Masa331

@Masa331
Copy link
Author

Masa331 commented Oct 22, 2020

Also added another commit which fixes this issue #18 which is due to code being wrapped in double <pre> tags and so having double padding around it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant