acceptGroupV4Invite #677
Merged
acceptGroupV4Invite #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroslopez
requested changes
Jun 2, 2021
There was a problem hiding this comment.
Cool!
This makes me think of a couple questions:
- Do the old invites still work?
- How do these differ from the old invites?
- Could something be done to make the existing
acceptInvitefunction work with the new format?
Also, it seems like typings are missing for the new acceptGroupV4Invite function.
1° - Yes, old invites are links, that anyone can join using them |
Added a description to the inviteV4 object Renamed "invite" by "inviteV4"
renamed "invite" to "inviteV4"
acceptGroupV4Invite
pedroslopez
approved these changes
Jun 5, 2021
|
Thanks! Tested this and it worked great. Just made a few changes to the typings. |
harish2704
added a commit
to harish2704/whatsapp-web.js
that referenced
this pull request
Jun 9, 2021
# By Pedro S. Lopez (3) and others # Via GitHub * 'master' of github.com:harish2704/whatsapp-web.js: Update lint.yml feat: acceptGroupV4Invite (pedroslopez#677) chore: update eslint and ecmaVersion (pedroslopez#680) chore: update lint action (pedroslopez#679) feat(dev): add argument bypassCSP to use in pupperter (pedroslopez#635) add searchMessages method (pedroslopez#586) feat: Add from which device the message was sent (pedroslopez#648) feat: disable / enable WA Web features (pedroslopez#543) feat: Get Orders and Products (pedroslopez#612) add extra option to MessageSendOptions (pedroslopez#600) feat: openChatWindow can open new chats (pedroslopez#592) Add sendVideoAsGif option (pedroslopez#578) Add support for sticker Name and author (pedroslopez#527) # Conflicts: # package.json
Belfio
pushed a commit
to Belfio/whatsapp-web.js
that referenced
this pull request
Jan 9, 2024
* Added option client.acceptGroupV4Invite() * Update Client.js * Update index.d.ts Added a description to the inviteV4 object Renamed "invite" by "inviteV4" * Update Client.js * Update Message.js renamed "invite" to "inviteV4" * Update Client.js * Added message.acceptGroupV4Invite method * Update index.d.ts acceptGroupV4Invite * better typings, refactor some names Co-authored-by: Pedro Lopez <pedroslopez@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.