Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getLastSeen method #553

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

wictornogueira
Copy link
Contributor

@wictornogueira wictornogueira commented Feb 17, 2021

closes #82

@pedroslopez
Copy link
Owner

pedroslopez commented Mar 1, 2021

I was initially trying to implement this back here ddfb616 but I haven't had time to finish it. Thanks for working on this!

The issue I encountered back then was that getting the presence information could be out of date or not accurate when retrieving it if you're not subscribed to their updates. This can be seen with people that are far down in the chat list.

Unfortunately the function used to subscribe to presence updates doesn't update the presence right away, so I was experimenting with how to accurately retrieve the state after subscribing. One could argue a setTimeout could be used with a fixed value, but I'd like to avoid this and use something more reliable. Would appreciate if you could look into this!

Also, I think having this method on the Contact would make more sense.

@pedroslopez pedroslopez added the enhancement New feature or request label Mar 1, 2021
@Invy55
Copy link

Invy55 commented Jul 23, 2021

I was initially trying to implement this back here ddfb616 but I haven't had time to finish it. Thanks for working on this!

The issue I encountered back then was that getting the presence information could be out of date or not accurate when retrieving it if you're not subscribed to their updates. This can be seen with people that are far down in the chat list.

Unfortunately the function used to subscribe to presence updates doesn't update the presence right away, so I was experimenting with how to accurately retrieve the state after subscribing. One could argue a setTimeout could be used with a fixed value, but I'd like to avoid this and use something more reliable. Would appreciate if you could look into this!

Also, I think having this method on the Contact would make more sense.

I was looking into this and I'm having trouble with data disappearing on a normal Firefox instance with manual code execution, any suggestion? I think it has to be something with focusing or the window not being used for some time. (I know this isn't strictly related but I'm hoping in some help)

@wictornogueira wictornogueira changed the title add getLastSeen method to Chat add getLastSeen method Aug 18, 2021
@LuisFilipe6
Copy link

Hello, is it still on the way?

Copy link
Collaborator

@tuyuribr tuyuribr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chat.presence.subscribe() needs to be reliable

@wictornogueira
Copy link
Contributor Author

Mfw yuri necroposts lol

@shirser121
Copy link
Collaborator

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check user online state. [feature request]
7 participants