fix: Constants export in index.js #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note2: I also added some missing contants that were in the Constants.js but not index.d,ts:
|
|
LGTM Thank you :) |
Belfio
pushed a commit
to Belfio/whatsapp-web.js
that referenced
this pull request
Jan 9, 2024
* fix: add Constants export in index.js * fix: add missing constants export in index.d.ts Co-authored-by: Pedro S. Lopez <pedroslopez@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an error while trying to use the enums present in index.d.ts; Example:
I found out that even though MessageType is defined in index.d.ts, it should also be exported in index.js, in order for it to be present at runtime.
This PR exports all the Constants in index.js and fixes the issue.
Note: I used the spread operator to export all the constants at once. If you think it should be better to export them individually, please let me know and I can try doing that also.