Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: group_join event #2320

Merged
merged 5 commits into from
Aug 6, 2023
Merged

Conversation

alechkos
Copy link
Collaborator

@alechkos alechkos commented Jul 1, 2023

PR Details

- Description

- Motivation and Context

- Related Issue

- Usage Example

- How Has the PR Been Tested

- Types of Changes


Description

Detection of users who join the group that is part of a community has been added.

Motivation and Context

It would make more sense if the group_join event is emitted when a user joins a group that is part of a community, instead of the group_update event as described in the #2163 by @ccastilhos.

Related Issue

PR closes #2163

Usage Example

client.on('group_join', (notification) => {

How Has This Been Tested

The functionality has been tested by verifying that it works when a user joins the group that is a part of a community.

Tested On

Types of accounts:

  • Personal
  • Buisness

Environment:

  • Android 10
  • Windows 10:
    • WWebJS v1.21.0
    • WWeb v2.2327.4
    • Node v16.17.1
    • Chrome 114.0.5735.199

To test this PR by yourself you can run one of the following commands:

# NPM
npm install github:alechkos/whatsapp-web.js#fix-on-group-join
# YARN
yarn add github:alechkos/whatsapp-web.js#fix-on-group-join

If you encounter any issues while testing this PR, please provide in a comment:

  1. The code you've used without any sensitive information (use syntax highlighting for more readability)
  2. The library version
  3. The WWeb version: console.log(await client.getWwebVersion());
  4. The browser (Chrome/Chromium)
  5. The error you got

Types of Changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

@shirser121
Copy link
Collaborator

LGTM

Copy link
Collaborator

@shirser121 shirser121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM

@shirser121 shirser121 merged commit dce964d into pedroslopez:main Aug 6, 2023
matiascamiletti pushed a commit to Tots-Agency/whatsapp-web.js that referenced this pull request Aug 10, 2023
* added linked_group_join subtype

* typo fixed from pr#2027

* fix: ESLint
dlimars pushed a commit to somosversotech/whatsapp-web.js that referenced this pull request Nov 7, 2023
* added linked_group_join subtype

* typo fixed from pr#2027

* fix: ESLint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Join based on Community
3 participants