forked from uber/cadence
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check for resurrected activities during RecordActivityTaskStarted (ub…
- Loading branch information
1 parent
4194b29
commit ee5461b
Showing
4 changed files
with
261 additions
and
140 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,177 @@ | ||
| // Copyright (c) 2022 Uber Technologies, Inc. | ||
| // Portions of the Software are attributed to Copyright (c) 2020 Temporal Technologies Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package execution | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/uber/cadence/common" | ||
| "github.com/uber/cadence/common/collection" | ||
| persistenceutils "github.com/uber/cadence/common/persistence/persistence-utils" | ||
| "github.com/uber/cadence/common/types" | ||
| "github.com/uber/cadence/service/history/shard" | ||
| ) | ||
|
|
||
| // GetResurrectedTimers returns a set of timers (timer IDs) that were resurrected. | ||
| // Meaning timers that are still pending in mutable state, but were already completed based on event history. | ||
| func GetResurrectedTimers( | ||
| ctx context.Context, | ||
| shard shard.Context, | ||
| mutableState MutableState, | ||
| ) (map[string]struct{}, error) { | ||
| // 1. find min timer startedID for all pending timers | ||
| pendingTimerInfos := mutableState.GetPendingTimerInfos() | ||
| minTimerStartedID := common.EndEventID | ||
| for _, timerInfo := range pendingTimerInfos { | ||
| minTimerStartedID = common.MinInt64(minTimerStartedID, timerInfo.StartedID) | ||
| } | ||
|
|
||
| // 2. scan history from minTimerStartedID and see if any | ||
| // TimerFiredEvent or TimerCancelledEvent matches pending timer | ||
| // NOTE: since we can't read from middle of an events batch, | ||
| // history returned by persistence layer won't actually start | ||
| // from minTimerStartedID, but start from the batch whose nodeID is | ||
| // larger than minTimerStartedID. | ||
| // This is ok since the event types we are interested in must in batches | ||
| // later than the timer started events. | ||
| resurrectedTimer := make(map[string]struct{}) | ||
| branchToken, err := mutableState.GetCurrentBranchToken() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| iter := collection.NewPagingIterator(getHistoryPaginationFn( | ||
| ctx, | ||
| shard, | ||
| minTimerStartedID, | ||
| mutableState.GetNextEventID(), | ||
| branchToken, | ||
| )) | ||
| for iter.HasNext() { | ||
| item, err := iter.Next() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| event := item.(*types.HistoryEvent) | ||
| var timerID string | ||
| switch event.GetEventType() { | ||
| case types.EventTypeTimerFired: | ||
| timerID = event.TimerFiredEventAttributes.TimerID | ||
| case types.EventTypeTimerCanceled: | ||
| timerID = event.TimerCanceledEventAttributes.TimerID | ||
| } | ||
| if _, ok := pendingTimerInfos[timerID]; ok && timerID != "" { | ||
| resurrectedTimer[timerID] = struct{}{} | ||
| } | ||
| } | ||
| return resurrectedTimer, nil | ||
| } | ||
|
|
||
| // GetResurrectedActivities returns a set of activities (schedule IDs) that were resurrected. | ||
| // Meaning activities that are still pending in mutable state, but were already completed based on event history. | ||
| func GetResurrectedActivities( | ||
| ctx context.Context, | ||
| shard shard.Context, | ||
| mutableState MutableState, | ||
| ) (map[int64]struct{}, error) { | ||
| // 1. find min activity scheduledID for all pending activities | ||
| pendingActivityInfos := mutableState.GetPendingActivityInfos() | ||
| minActivityScheduledID := common.EndEventID | ||
| for _, activityInfo := range pendingActivityInfos { | ||
| minActivityScheduledID = common.MinInt64(minActivityScheduledID, activityInfo.ScheduleID) | ||
| } | ||
|
|
||
| // 2. scan history from minActivityScheduledID and see if any | ||
| // activity termination events matches pending activity | ||
| // NOTE: since we can't read from middle of an events batch, | ||
| // history returned by persistence layer won't actually start | ||
| // from minActivityScheduledID, but start from the batch whose nodeID is | ||
| // larger than minActivityScheduledID. | ||
| // This is ok since the event types we are interested in must in batches | ||
| // later than the activity scheduled events. | ||
| resurrectedActivity := make(map[int64]struct{}) | ||
| branchToken, err := mutableState.GetCurrentBranchToken() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| iter := collection.NewPagingIterator(getHistoryPaginationFn( | ||
| ctx, | ||
| shard, | ||
| minActivityScheduledID, | ||
| mutableState.GetNextEventID(), | ||
| branchToken, | ||
| )) | ||
| for iter.HasNext() { | ||
| item, err := iter.Next() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| event := item.(*types.HistoryEvent) | ||
| var scheduledID int64 | ||
| switch event.GetEventType() { | ||
| case types.EventTypeActivityTaskCompleted: | ||
| scheduledID = event.ActivityTaskCompletedEventAttributes.ScheduledEventID | ||
| case types.EventTypeActivityTaskFailed: | ||
| scheduledID = event.ActivityTaskFailedEventAttributes.ScheduledEventID | ||
| case types.EventTypeActivityTaskTimedOut: | ||
| scheduledID = event.ActivityTaskTimedOutEventAttributes.ScheduledEventID | ||
| case types.EventTypeActivityTaskCanceled: | ||
| scheduledID = event.ActivityTaskCanceledEventAttributes.ScheduledEventID | ||
| } | ||
| if _, ok := pendingActivityInfos[scheduledID]; ok && scheduledID != 0 { | ||
| resurrectedActivity[scheduledID] = struct{}{} | ||
| } | ||
| } | ||
| return resurrectedActivity, nil | ||
| } | ||
|
|
||
| func getHistoryPaginationFn( | ||
| ctx context.Context, | ||
| shard shard.Context, | ||
| firstEventID int64, | ||
| nextEventID int64, | ||
| branchToken []byte, | ||
| ) collection.PaginationFn { | ||
| return func(token []byte) ([]interface{}, []byte, error) { | ||
| historyEvents, _, token, _, err := persistenceutils.PaginateHistory( | ||
| ctx, | ||
| shard.GetHistoryManager(), | ||
| false, | ||
| branchToken, | ||
| firstEventID, | ||
| nextEventID, | ||
| token, | ||
| NDCDefaultPageSize, | ||
| common.IntPtr(shard.GetShardID()), | ||
| ) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
|
|
||
| var items []interface{} | ||
| for _, event := range historyEvents { | ||
| items = append(items, event) | ||
| } | ||
| return items, token, nil | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.