fix(cga): inspect padding shares the removed yellow, not flat white#59
Merged
Conversation
In inspect mode the cga padding was flat bright white, unlike amber/green which dim their hue for padding. White has no relationship to the rest of the palette, so it read as flat. Use the same bright yellow the diff uses for removed lines — wasted padding reads like a removal — giving inspect a real CGA color. Header stays bold magenta; inspect goldens render Color:false so no fixtures change. Closes #58 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In inspect mode the
cgapalette rendered padding as flat bright white, unlikeamber/greenwhich dim their single hue for padding (bold-hue header + faint-hue padding two-tone). White had no relationship to the rest of the CGA palette, so it read as flat.Now CGA inspect padding uses bright yellow — the same color the diff uses for removed lines — tying "wasted padding" to "removed" and giving inspect a real CGA color. Header stays bold magenta.
Test plan
theme_internal_test.go: added an assertion thatcga.Paddingrenders bright yellow (93).Color: false, so no fixtures change.task cigreen (154 tests, 0 lint issues); verified against./_example.Closes #58
🤖 Generated with Claude Code