fix: legible CGA palette and 'total' in summary line#44
Merged
Conversation
Two small UX polish items: - Retheme the CGA easter egg to the iconic mode-4 palette 1 (cyan/magenta/white) with a reverse-video magenta header bar. The previous palette merely brightened the default colors, which many terminals render identically to bold+standard, so it was effectively invisible. - Append "total" to the -summary line: "Summary: N structs affected, M bytes saved total", clarifying the byte count is an aggregate. Closes #43 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #44 +/- ##
=======================================
Coverage 92.88% 92.88%
=======================================
Files 12 12
Lines 871 871
=======================================
Hits 809 809
Misses 34 34
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous small UX fixes.
CGA palette legibility
The
-cgaeaster-egg theme previously just brightened the default palette (bright cyan/green/red). On many terminals that's indistinguishable from the default — bold + standard colors render identically to their bright variants — so the egg was effectively invisible.Rethemed to the iconic CGA mode-4 palette 1 (cyan / magenta / white):
Now visibly distinct from the default.
TestCgaThemeIsDistinctFromDefaultlocks in the intent. The default theme (and its golden fixtures) are untouched.Summary wording
-summarynow readsSummary: N structs affected, M bytes saved total, clarifying the byte count is an aggregate across all shown structs.Closes #43
🤖 Generated with Claude Code