Skip to content

flake: use pebble-tool from the overlay - #16

Merged
Sorixelle merged 1 commit into
pebble-dev:mainfrom
t184256:flake-pebble-tool-fix
Jun 1, 2026
Merged

flake: use pebble-tool from the overlay#16
Sorixelle merged 1 commit into
pebble-dev:mainfrom
t184256:flake-pebble-tool-fix

Conversation

@t184256

@t184256 t184256 commented May 30, 2026

Copy link
Copy Markdown
Contributor

Fixes: #15

@Sorixelle Sorixelle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna be honest, I haven't been testing that one because I assumed it was broken and didn't work anyway. Thanks for catching that! Just add a Signed-Off-By to your commits as per the contributing guidelines and it'll be good to merge.

Fixes: pebble-dev#15
Signed-off-by: Alexander Sosedkin <monk@unboiled.info>
@t184256
t184256 force-pushed the flake-pebble-tool-fix branch from e259e66 to a33a0c2 Compare May 31, 2026 15:33
@t184256

t184256 commented May 31, 2026

Copy link
Copy Markdown
Contributor Author

Sure, added Signed-off-by.

(Will open another PR soon with a few more fixes; ideally I'd like to add an integration test that'd build a couple of existing projects using buildPebbleApp.)

@t184256

t184256 commented May 31, 2026

Copy link
Copy Markdown
Contributor Author

(#17 is the follow-up)

@Sorixelle

Copy link
Copy Markdown
Member

Awesome, thanks!

@Sorixelle
Sorixelle merged commit 51f2a26 into pebble-dev:main Jun 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buildPebbleApp broken since 7aca2ec: packages.pebble-tool -> pkgs.pebble-tool?

2 participants