-
Notifications
You must be signed in to change notification settings - Fork 47
Watches Page UI Recreation in kotlin #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: kmp
Are you sure you want to change the base?
Conversation
Seems like this is ticket #305 |
Yep! I should have mentioned that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a bunch of comments, feel free to ping me if you need any help!
Also, I'd suggest to fix the formatting, its kinda off and also put all the string into resources for future localization
...rc/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchBottomSheetContent.kt
Outdated
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchBottomSheetContent.kt
Outdated
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchBottomSheetContent.kt
Outdated
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchBottomSheetContent.kt
Outdated
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchBottomSheetContent.kt
Outdated
Show resolved
Hide resolved
...oid/shared/src/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchesPage.kt
Outdated
Show resolved
Hide resolved
...oid/shared/src/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchesPage.kt
Outdated
Show resolved
Hide resolved
...oid/shared/src/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchesPage.kt
Outdated
Show resolved
Hide resolved
...oid/shared/src/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchesPage.kt
Outdated
Show resolved
Hide resolved
...oid/shared/src/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchesPage.kt
Outdated
Show resolved
Hide resolved
android/shared/src/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/HomeScaffold.kt
Outdated
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/watches/WatchBottomSheetContent.kt
Outdated
Show resolved
Hide resolved
android/shared/schemas/io.rebble.cobble.shared.database.AppDatabase/13.json
Outdated
Show resolved
Hide resolved
@hellcp Thanks for reviewing my code! lemme know if any other changes need to be made. |
Remade the UI for the watches tab in kotlin. Didn't work on the functionality part yet. To access it, go through the locker tab route and it should be there