Skip to content

Commit

Permalink
add PEAR/Error.php dummy file
Browse files Browse the repository at this point in the history
  • Loading branch information
@cweiske
cweiske committed Feb 10, 2015
1 parent eb10916 commit f1864ea
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions src/PEAR/Error.php
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?php
/**
* Dummy file to make autoloaders work
*
* PHP version 5
*
* @category PEAR
* @package PEAR
* @author Christian Weiske <cweiske@php.net>
* @license http://opensource.org/licenses/bsd-license.php New BSD License
* @link http://pear.php.net/package/PEAR
*/
require_once __DIR__ . '/../PEAR.php';
?>

This comment has been minimized.

Sign in to view

Copy link
@glensc

glensc Apr 7, 2015

Contributor

is the php close tag neccessary?

also use of __DIR__ disallows php 5.2 :)

5 comments on commit f1864ea

@cweiske
Copy link
Member Author

@cweiske cweiske commented on f1864ea Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yes, per PEAR CS
  2. We're moving PEAR to PHP 5.4+, so 5.2 doesn't matter anymore.

@glensc
Copy link
Contributor

@glensc glensc commented on f1864ea Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i understand nuking 5.2 support, but as composer supports 5.3.3, seems reasonable to keep 5.3 support

@cweiske
Copy link
Member Author

@cweiske cweiske commented on f1864ea Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because composer supports 5.3 doesn't mean we have to. This is not a good reason.

@glensc
Copy link
Contributor

@glensc glensc commented on f1864ea Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just migrated (with pain) 5.2 -> 5.3. you will be locking out such users who stuck to 5.3

@kenguest
Copy link
Member

@kenguest kenguest commented on f1864ea Apr 7, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.