URL2: Fix implicit null declaration

[reedy]

https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

Fixed: https://pear.php.net/bugs/bug.php?id=28649

[reedy]

This probably does require a newer version of PHP than 5.1.6 as per https://github.com/pear/Net_URL2/blob/master/composer.json#L34...

But when CI seemingly isn't working etc... :)

Started fixing that in #15

[reedy]

This probably does require a newer version of PHP than 5.1.6 as per https://github.com/pear/Net_URL2/blob/master/composer.json#L34...

7.1.0 it would seem - https://3v4l.org/F0lJH

Which therefore requires bumping the minimum required version

7.1 was released 1 December 2016, EOL 1 December 2019...

[hakre]

Thanks for reporting this, please use the opportunity to touch this for PHP 9.0 forwards compatibility and make the parameter non-optional.

This not only improves the code but also retains backwards compatibility.

[reedy]

This not only improves the code but also retains backwards compatibility.

At some point, supporting such old PHP versions doesn't make a lot of sense... Though, I guess when we can do it without breaking backwards compatability...

I guess I should update #15 to not change the required PHP version then too?

[hakre]

This not only improves the code but also retains backwards compatibility.

At some point, supporting such old PHP versions doesn't make a lot of sense... Though, I guess when we can do it without breaking backwards compatability...

Yes, and thinking: this supports PHP 9.0 which is the opposite of old.

I guess I should update #15 to not change the required PHP version then too?

Ah #15, yes, please update.

[reedy]

This not only improves the code but also retains backwards compatibility.

At some point, supporting such old PHP versions doesn't make a lot of sense... Though, I guess when we can do it without breaking backwards compatability...

Yes, and thinking: this supports PHP 9.0 which is the opposite of old.

Well, I was more meaning 5.6 (and 5.1 as per composer.json currently)

I guess I should update #15 to not change the required PHP version then too?

Ah #15, yes, please update.

Already done! :)

[hakre]

Well, I was more meaning 5.6 (and 5.1 as per composer.json currently)

There is no need to change composer.json now, so that is not an issue. But if, then I'm totally with you that one needs to take many more things into consideration including which PHP versions are supported.

For the deprecation message btw., I've found it helpful in some more projects already to highlight some places for smaller refactorings that untangle needless null defaults and even default values at all. The analysis of existing code presented in the RFC only scratches the surface IMHO.