-
Notifications
You must be signed in to change notification settings - Fork 27
Add legacy include path option. #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Other PEAR packages like HTTP_Request2 that depend on Net_URL2 expect the include path to be set.
Thanks for your report. IIRC there was (?) an issue report for HTTP_Request2 on Github about it, but I can't find it right now, I would have liked to reference it here. There is a fairly recent version which still have the include path setting so packages that depend on it can specify the version (which they should anyway). For PSR-0: Why the switch? What is the benefit compared to classmap? |
Upstream report was here: Bug #20531 - Net_URL2 2.2.0 has switched to classmap autoloader (Apr 2015). Also seeing traction by pear/HTTP_Request2#12. |
No benefit to psr-0 vs classmap. I figured since the package is structured to use PSR-0 it made sense. |
HTTP_Request2 is updated to work without the legacy include_path but several other dependent pear packages are not updated. Additionally, user space code that depends on Net_URL may still be using require_once calls. |
I like your recommendation that dependencies that need an include path specify |
We're PEAR. PEAR used PSR-0 long before it was officially named so. |
@cweiske: Hmm, it works the PSR-0 way with the PEAR package. That has not been changed.PSR-0 is 100% perfectly working, just grab the package (e.g. Net_URL2-2.2.0.tgz), it's flawless. From what I've read this PR is not about PEAR but Composer, and it's causing others problems that make use of it via Composer (and not via PEAR), |
That's correct, if installed into a PEAR tree with pyrus or pear, Net_URL2 still works as it always has. This PR is specifically for installing it via composer and working with code that was originally written for use with a PEAR tree rather than a composer tree. |
So for those who manually port pear packages to be used with composer. Hmm. I'm a bit biased here but at least it should be possible to have two branches: 2.2.x w/o and 2.1.x with that. Would that be reasonable? |
@gauthierm: You find the latest updates as v2.1.2 with leagcy include support. Just FYI. |
I just had the same problem with Services_Yadis which relies on include path. |
@cweiske: Just use the 2.1.x version, it has that feature. The 2.2.x is w/o... (IIRC) |
Other PEAR packages like HTTP_Request2 that depend on Net_URL2 expect the include path to be set.
Also switch the autoloader from classmap to psr-0.