test(eslint-plugin): add extra tests (typescript-eslint#10587)

* test(eslint-plugin): add extra tests Adds a couple of extra test cases for these rules: - `class-methods-use-this` - `consistent-type-assertions` - `no-array-delete` * test: update no-array-delete test to remove comment Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
peanutenthusiast · Jan 7, 2025 · 03d9639 · 03d9639
1 parent e697cfa
commit 03d9639
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 0 deletions.
diff --git a/packages/eslint-plugin/tests/rules/class-methods-use-this/class-methods-use-this.test.ts b/packages/eslint-plugin/tests/rules/class-methods-use-this/class-methods-use-this.test.ts
@@ -549,6 +549,22 @@ class Foo implements Bar {
         },
       ],
     },
+    {
+      code: `
+function fn() {
+  this.foo = 303;
+
+  class Foo {
+    method() {}
+  }
+}
+      `,
+      errors: [
+        {
+          messageId: 'missingThis',
+        },
+      ],
+    },
   ],
   valid: [
     {

diff --git a/packages/eslint-plugin/tests/rules/consistent-type-assertions.test.ts b/packages/eslint-plugin/tests/rules/consistent-type-assertions.test.ts
@@ -157,6 +157,18 @@ ruleTester.run('consistent-type-assertions', rule, {
         },
       },
     },
+    {
+      code: `
+const x = { key: 'value' } as any;
+      `,
+      options: [{ assertionStyle: 'as', objectLiteralTypeAssertions: 'never' }],
+    },
+    {
+      code: `
+const x = { key: 'value' } as unknown;
+      `,
+      options: [{ assertionStyle: 'as', objectLiteralTypeAssertions: 'never' }],
+    },
   ],
   invalid: [
     ...dedupeTestCases(

diff --git a/packages/eslint-plugin/tests/rules/no-array-delete.test.ts b/packages/eslint-plugin/tests/rules/no-array-delete.test.ts
@@ -55,6 +55,9 @@ ruleTester.run('no-array-delete', rule, {
       declare const test: never;
       delete test[0];
     `,
+    `
+      delete console.log();
+    `,
   ],
 
   invalid: [
@@ -596,5 +599,28 @@ ruleTester.run('no-array-delete', rule, {
         },
       ],
     },
+    {
+      code: `
+        declare const arr: string & Array<number>;
+        delete arr[0];
+      `,
+      errors: [
+        {
+          column: 9,
+          endColumn: 22,
+          line: 3,
+          messageId: 'noArrayDelete',
+          suggestions: [
+            {
+              messageId: 'useSplice',
+              output: `
+        declare const arr: string & Array<number>;
+        arr.splice(0, 1);
+      `,
+            },
+          ],
+        },
+      ],
+    },
   ],
 });