Skip to content

Add explicit buffers for AWS uploader and downloader #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add explicit buffers for AWS uploader and downloader #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03d8360
Add explicit buffers for AWS uploader and downloader
Oct 20, 2025
0e791a3
fix docker image
Oct 20, 2025
236a09f
fix docker image
Oct 20, 2025
b62167d
fix mock
Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
runs-on: ${{ matrix.os }}-latest
services:
minio:
image: ${{ (matrix.os == 'ubuntu') && 'bitnami/minio:2023.7.18' || ''}}
image: ${{ (matrix.os == 'ubuntu') && 'quay.io/minio/minio:latest' || '' }}
ports:
- 45677:9000
options: >-
Expand All @@ -56,6 +56,7 @@ jobs:
env:
MINIO_ROOT_USER: minioadmin
MINIO_ROOT_PASSWORD: minioadmin
command: server /data --console-address ":9001"
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
Expand Down
1 change: 1 addition & 0 deletions storage/mock_storage.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions storage/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ const (

// the key of the object metadata which is used to handle retry decision on NoSuchUpload error
metadataKeyRetryID = "s5cmd-upload-retry-id"

DownloaderBufferSize = 64 * 1024
UploaderBufferSize = 512 * 1024
)

// Re-used AWS sessions dramatically improve performance.
Expand Down Expand Up @@ -102,10 +105,15 @@ func newS3Storage(ctx context.Context, opts Options) (*S3, error) {
return nil, err
}

downloader := s3manager.NewDownloader(awsSession)
downloader.BufferProvider = s3manager.NewPooledBufferedWriterReadFromProvider(DownloaderBufferSize)
uploader := s3manager.NewUploader(awsSession)
uploader.BufferProvider = s3manager.NewBufferedReadSeekerWriteToPool(UploaderBufferSize)

return &S3{
api: s3.New(awsSession),
downloader: s3manager.NewDownloader(awsSession),
uploader: s3manager.NewUploader(awsSession),
downloader: downloader,
uploader: uploader,
endpointURL: endpointURL,
dryRun: opts.DryRun,
useListObjectsV1: opts.UseListObjectsV1,
Expand Down