-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
enhancementNew feature or requestNew feature or request
Milestone
Description
Context
v0.10.9 added typecheck:apps as an advisory CI step (continue-on-error: true), mirroring the typecheck:legacy pattern. This provides visibility without blocking release.
Current State
Two apps have pre-existing typecheck errors:
apps/api (3 errors):
src/index.ts:68-- Honoc.body()overload mismatch (string vs StatusCode). Fix: usec.json()or cast status.src/verifier.ts:7-8--@peac/corelacks.d.tsexports. Fix: add types to@peac/coreor sunset the import.
apps/bridge (3 errors):
src/routes/enforce.ts:11,src/routes/readiness.ts:10-- same@peac/coremissing typessrc/routes/readiness.ts:29,src/routes/verify.ts:44--@peac/app-apimodule not found
apps/sandbox-issuer and apps/verifier pass clean.
Fix Strategy
@peac/coretypes: Addtypesfield to@peac/core/package.jsonpointing to.d.tsoutput, or add explicitdeclare module '@peac/core'shims in consuming apps (if sunsetting the package).- Hono overload: Replace
c.body(JSON.stringify(problem), problem.status)withc.json(problem, problem.status as StatusCode)or use Hono's typed response helpers. @peac/app-apimodule: Verify bridge still needs this import, fix or remove.- Flip CI: Remove
continue-on-error: truefromtypecheck:appsstep once all errors resolved.
Acceptance Criteria
-
pnpm typecheck:appspasses with zero errors - CI step is mandatory (no
continue-on-error)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request