Skip to content

Fix #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peachisai merged 2 commits into from
Nov 2, 2025
Merged

Fix #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8387a6c
Fix
peachisai Nov 2, 2025
a976175
Fix
peachisai Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apm-sniffer/bootstrap-plugins/jdk-httpclient-plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.release>11</maven.compiler.release>
<compiler.version>11</compiler.version>
</properties>

<build>
Expand Down
13 changes: 9 additions & 4 deletions ...plugin/src/main/java/org/apache/skywalking/apm/plugin/HttpClientSendAsyncInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
import java.net.URI;
import java.net.http.HttpRequest;
import java.net.http.HttpResponse;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.CompletableFuture;

public class HttpClientSendAsyncInterceptor implements InstanceMethodsAroundInterceptor {
Expand Down Expand Up @@ -63,13 +65,14 @@ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allA

if (ret != null) {
CompletableFuture<?> future = (CompletableFuture<?>) ret;
future.whenComplete((response, throwable) -> {
ret = future.whenComplete((response, throwable) -> {
try {
if (throwable != null) {
Tags.HTTP_RESPONSE_STATUS_CODE.set(span, 500);
span.errorOccurred();
span.log(throwable);
} else if (response instanceof HttpResponse) {
return;
}
if (response instanceof HttpResponse) {
HttpResponse<?> httpResponse = (HttpResponse<?>) response;
int statusCode = httpResponse.statusCode();
Tags.HTTP_RESPONSE_STATUS_CODE.set(span, statusCode);
Expand All @@ -82,7 +85,9 @@ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allA
}
});
} else {
Tags.HTTP_RESPONSE_STATUS_CODE.set(span, 404);
Map<String, String> eventMap = new HashMap<String, String>();
eventMap.put("error", "No response");
span.log(System.currentTimeMillis(), eventMap);
span.errorOccurred();
}
ContextManager.stopSpan();
Expand Down
Loading