Skip to content

Nominal Release Review and Merge

Jump to bottom
Jordan Padams edited this page Oct 21, 2022 · 2 revisions

Pull requests should already be created in your repos with the new IM added to your builds (updated pds4_versions.txt). A how-to guide on reviewing a pull request can be found here: https://pds-data-dictionaries.github.io/development/ldd-how-to.html#reviewing-a-pull-request

If the build failed (red X next to the commit), this means something went wrong. Head the Actions tab to see what went wrong.

If the build was successful (green checkmark next to commit), this means everything built and validated as expected. Please review the branch and the generated LDDs to verify they were generated as expected.

Once you have completed your review and everything builds successfully, feel free to approve and merge the pull request. Once merged, this new version of the LDD will be automatically included in the new PDS Data Dictionaries web page when the IM is released.

NOTE: Only the new version LDD built with the new version of the PDS4 Information Model will be released with the IM. For example, if this is a build for PDS4 v1.19.0.0 (1J00), on the 1J00 version of the LDD will be released (e.g. PDS4_IMG_1000_1J00). If you would like the LDD released for other IM versions, you will need to submit a request for the other versions here.

Testing Tips

Automated Testing

Ideally you would have some regression test files under the test/ directory in your repo. If not, you can test manually using validate, as noted below.

Validate

Since the PDS4 Information Model is a "candidate" release, updates are deployed into develop directories through the beta testing and I&T lifecycle. When attempting to test with validate, there are a few ways you can "point" your labels towards this candidate release of the IM:

  1. Specify the schemas / schematron via command-line, e.g.
# Assuming you have downloaded the schema and schematron to your current directory where you are running validate
validate -x PDS4_PDS_1H00.xsd -S PDS4_PDS_1H00.sch -t my_test_product.xml

  1. Use an XML Catalog file

  2. Update your schematron URLs and schemaLocation to point to the candidate release URLs (note: this will only work for :

<!-- Before -->
<?xml-model href="https://pds.nasa.gov/pds4/pds/v1/PDS4_PDS_1G00.sch"?>

<!-- After -->
<?xml-model href="https://pds.nasa.gov/datastandards/schema/develop/pds/PDS4_PDS_1H00.sch"?>

<!-- Before -->
 xsi:schemaLocation="http://pds.nasa.gov/pds4/pds/v1 
                     https://pds.nasa.gov/pds4/pds/v1/PDS4_PDS_1G00.xsd">

<!-- After -->
 xsi:schemaLocation="http://pds.nasa.gov/pds4/pds/v1 
                     https://pds.nasa.gov/datastandards/schema/develop/pds/PDS4_PDS_1H00.xsd">
Clone this wiki locally