Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctype #887

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Add doctype #887

merged 1 commit into from
Feb 6, 2022

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Feb 5, 2022

Pull Request Check List

Its a temporary solution, should migrate to html.parser as html5lib will be deprecated. New parser requires doctypes.
Or add html5lib/another parser as a dependency.

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2022

Codecov Report

Merging #887 (5672d85) into main (42edab5) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
+ Coverage   83.75%   83.77%   +0.01%     
==========================================
  Files          74       74              
  Lines        6359     6359              
  Branches     1316     1316              
==========================================
+ Hits         5326     5327       +1     
+ Misses        711      710       -1     
  Partials      322      322              
Flag Coverage Δ
unittests 83.53% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/models/pip_shims.py 88.67% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d7945...5672d85. Read the comment docs.

@frostming frostming merged commit 459a298 into pdm-project:main Feb 6, 2022
@q0w q0w mentioned this pull request Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants