Add missing verbosity flag

[q0w]

#874

Pull Request Check List

• A news fragment is added in news/ describing what is new.
• Test cases added for changed code.

Describe what you have changed in this PR.

[CharString]

This would solve #874

[pawamoy]

Is the flag backported to previous pip versions? If not, and if always using it in PDM, then I think the minimum required pip version in pyproject.toml should also be upgraded? unpack_url does not swallow extra keyword arguments.

[frostming]

You need to ensure the fix works for the specified version range of pip in dependencies. But before that, I will cut a new release pinning pip<22 to fix the breakage.

Thanks

[q0w]

Should I check if unpack_url has verbosity flag in function signature?

[pawamoy]

This, or check pip's version using importlib.metadata.

[frostming]

This needs to be done in the pip_shims module, and other modules just import and use it. That is what the name pip_shims stands for.

[q0w]

This needs to be done in the pip_shims module, and other modules just import and use it. That is what the name pip_shims stands for.

Ok. Should it be tested somehow?

[codecov-commenter]

Codecov Report

Merging #875 (b78b7f1) into main (40cd92b) will decrease coverage by 0.51%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   83.86%   83.34%   -0.52%     
==========================================
  Files          74       74              
  Lines        6353     6359       +6     
  Branches     1315     1316       +1     
==========================================
- Hits         5328     5300      -28     
- Misses        707      746      +39     
+ Partials      318      313       -5     

Flag	Coverage Δ
unittests	83.11% <33.33%> (-0.52%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pdm/models/pip_shims.py	86.79% <33.33%> (-3.21%)	⬇️
pdm/models/setup.py	42.29% <0.00%> (-10.28%)	⬇️
pdm/core.py	87.06% <0.00%> (-1.43%)	⬇️
pdm/models/repositories.py	76.44% <0.00%> (-0.89%)	⬇️
pdm/formats/poetry.py	91.79% <0.00%> (-0.75%)	⬇️
pdm/installers/installers.py	83.92% <0.00%> (-0.60%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40cd92b...b78b7f1. Read the comment docs.

[frostming]

Thanks