Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the support for relative paths from outside the project #1432

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Oct 13, 2022

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Base: 84.94% // Head: 84.92% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (1700a3b) compared to base (901c5e2).
Patch coverage: 93.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1432      +/-   ##
==========================================
- Coverage   84.94%   84.92%   -0.03%     
==========================================
  Files          88       88              
  Lines        7605     7620      +15     
  Branches     1777     1784       +7     
==========================================
+ Hits         6460     6471      +11     
- Misses        762      765       +3     
- Partials      383      384       +1     
Flag Coverage Δ
unittests 84.73% <93.61%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/models/requirements.py 94.73% <86.66%> (-0.48%) ⬇️
src/pdm/models/repositories.py 78.04% <92.85%> (+0.08%) ⬆️
src/pdm/cli/actions.py 80.27% <100.00%> (+0.13%) ⬆️
src/pdm/models/candidates.py 87.61% <100.00%> (+0.03%) ⬆️
src/pdm/project/core.py 89.20% <100.00%> (ø)
src/pdm/models/caches.py 87.71% <0.00%> (-1.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 2d6b898 into main Oct 13, 2022
@frostming frostming deleted the fix/relative-path-outside-project branch October 13, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants