Fix #737, with random_init of distribution_safe_integral - #738
Open
JAuriac wants to merge 1 commit into
Open
Conversation
JAuriac
force-pushed
the
737_IntegralRandomInit
branch
from
August 4, 2026 08:23
1cb7396 to
82bc122
Compare
JAuriac
force-pushed
the
737_IntegralRandomInit
branch
from
August 4, 2026 08:26
82bc122 to
55a2a35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #735.
For exactly the integer types std::uniform_int_distribution permits, as its IntType parameter (short, int, long, long long, and unsigned variants). bool and char-like types are intentionally excluded as uniform_int_distribution is undefined behavior for those, and this file doesn't provide an alternative for them. A struct containing a bool or char member will fail to compile here rather than compile into a runtime undefined behavior.
To handle bool and char, the following would be needed :
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format;Fix #issuekeyword to autoclose the issue when merged.