Minor tweaks to existing docs, added Table of Content examples, added TODOs #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmummau
changed the title
|
Merged. Thanks. On fontFeatures and columnGap aswered here: #10 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm reviewing @types/pdfmake and while doing so, I'm also reviewing the docs. I noticed some differences here that needed tidied up.
The Table-cell properties that I'm removing are ones that I noticed are commented out in the styleContentStack.js so I don't think they add any value to the docs.
I wasn't able to add an accurate comment for
fontFeaturesorcolumnGap. If someone could give me direction as to how to describe these styles, then we could add them to the docs.