Fix an example of using images #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using rollup as a project bundler introduces two problems with pdfmake: 1. rollup won't allow for reassigning imported module (see rollup/rollup#436), so there is no way to assign vfs fonts manually. 2. rollup won't parse vfs_fonts.js, since it uses `this` at top level, with is by default set by rollup to `undefined` (see https://rollupjs.org/guide/en/#error-this-is-undefined) To resolve both issues, `this` for pdfmake needs to be set to `window`, with `options.moduleContext` in rollup config, and then fonts assignments needs to happen before importing pdfmake to rollup scope (fortunately, since `this` in vfs_fonts is now `window`, it will do the assignment automatically).
Add rollup instructions
On macOS the shell script does not produce usable output. The `-n` is present in the resulting js file which causes the newlines to be present as well which then causes the js file to be invalid. The "oneliner" echo version with variables does work in macOS, however. (I changed the `-b` back to `-w` here) If this also works on other OS, it might be worth to change in the example code.
Missing comma after strawberries url.
|
Thanks. Merged via 98fb40b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it left a comma in the example, so i just added it to avoid problems with it.