test improvements open-telemetry#2

pdelewski · Aug 22, 2023 · c1c8655 · c1c8655
1 parent 8065b1f
commit c1c8655
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/instrgen/driver/instrgen_test.go b/instrgen/driver/instrgen_test.go
@@ -174,22 +174,17 @@ func TestExecutePass(t *testing.T) {
 func TestDriverMain(t *testing.T) {
 	executor := &NullExecutor{}
 	{
-		os.Remove("instrgen_cmd.json")
+		err := os.Remove("instrgen_cmd.json")
+		_ = err
 		var args []string
 		args = append(args, "compile")
-		err := driverMain(args, executor)
+		err = driverMain(args, executor)
 		require.Error(t, err)
 	}
 	for k := range testcases {
 		var args []string
 		files := alib.SearchFiles(k, ".go")
-		args = append(args, "-o")
-		args = append(args, "/tmp/go-build")
-		args = append(args, "-p")
-		args = append(args, "main")
-		args = append(args, "-pack")
-		args = append(args, "-asmhdr")
-		args = append(args, "go_asm.h")
+		args = append(args, []string{"-o", "/tmp/go-build", "-p", "main", "-pack", "-asmhdr", "go_asm.h"}...)
 		args = append(args, files...)
 		var instrgenCfg InstrgenCmd
 		instrgenCfg.FilePattern = k